Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few additions for the sea ice. #157

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

A few additions for the sea ice. #157

wants to merge 26 commits into from

Conversation

dabail10
Copy link
Collaborator

@dabail10 dabail10 commented Nov 22, 2024

Description of changes:

  • Added new Hemis_seaice_visual_compare_obs_lens.ipynb which is a start to the sea ice key metrics.
  • modified the list of variables for the seaice notebook to make it faster. There is a new cice_vars_full.yml list
  • updated the sea ice runs in config.yml
  • changed the color table
  • fixed the options for the cluster
  • to do: configure the config.yml for sea ice in the key_metrics directory

Copy link
Collaborator

@TeaganKing TeaganKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dabail10 , thanks for making these additions!

I also have a few very minor change requests:

  1. Could you please title your notebooks something descriptive? Our recommended format is <region>_<variable>_<metric>_<comparisons>.ipynb; for instance, this might look like Global_PSL_NMSE_compare_obs_lens.ipynb or Greenland_SMB_visual_compare_obs.ipynb.
  2. It looks like there is some commented out code in both of the notebooks-- if this is not going to be used, can you please remove it? Or, if the commented out code is going to be used in some circumstances, maybe it could be in a in 'if' statement?

@dabail10
Copy link
Collaborator Author

dabail10 commented Dec 4, 2024

Hi @dabail10 , thanks for making these additions!

I also have a few very minor change requests:

  1. Could you please title your notebooks something descriptive? Our recommended format is <region>_<variable>_<metric>_<comparisons>.ipynb; for instance, this might look like Global_PSL_NMSE_compare_obs_lens.ipynb or Greenland_SMB_visual_compare_obs.ipynb.
  2. It looks like there is some commented out code in both of the notebooks-- if this is not going to be used, can you please remove it? Or, if the commented out code is going to be used in some circumstances, maybe it could be in a in 'if' statement?

I have addressed the first part. I need some of the commented out code as I want to use this eventually for reading the LENS data.

@dabail10
Copy link
Collaborator Author

dabail10 commented Dec 4, 2024

I have got this to work (at least read data) with the examples/key_metrics/config.yml file. I am still working on the computing of an annual average. The new way of reading in the datasets messed up my resample/groupby. More to come.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants